Add an option to disable QEMU testing #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithp35
reviewed
Dec 2, 2024
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
Code change LGTM, I think we may want to change the help text.
arm-multilib/CMakeLists.txt
Outdated
| file(READ ${variant_json_file} variant_json_str) | ||
| string(JSON test_executor GET ${variant_json_str} "args" "common" "TEST_EXECUTOR") | ||
|
|
||
| # FVP testing should default to off, so override any |
Contributor
There was a problem hiding this comment.
Does this comment need to be revised now that both FVP and QEMU testing is optional?
arm-multilib/CMakeLists.txt
Outdated
| set(LIBC_HDRGEN "" CACHE PATH "Path to prebuilt lbc-hdrgen if not included in LLVM binaries set by LLVM_BINARY_DIR") | ||
| option( | ||
| ENABLE_QEMU_TESTING | ||
| "Tests using QEMU are enabled by default, but can be disabled." |
Contributor
There was a problem hiding this comment.
The help text, while correct, doesn't fit well with ENABLE_QEMU_TESTING. It would fit better with a DISABLE_QEMU_TESTING option.
Perhaps
Enable tests that use QEMU. This option is ON by default.
If the text is changed, would be good to update the other places too.
Collaborator
Author
There was a problem hiding this comment.
Done, and updated FVP options to match.
Testing with QEMU is implicitly enabled by default, but configuring the project to run with tests requires QEMU. As testing with QEMU is considered optional, it should be possible to disable tests when QEMU is not available or testing is not needed. Since there is already an option for controlling FVP testing, this patch adds a similar option for QEMU, ENABLE_QEMU_TESTING, which instead defaults to ON. This can then be turned off when QEMU is not installed, so that configurations where QEMU is expected can suitably detect and show an error when it is missing.
dcandler
force-pushed
the
enable_qemu_option
branch
from
2148e46 to
2c8cc0f
Compare
smithp35
approved these changes
Dec 2, 2024
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
LGTM, thanks for the update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with QEMU is implicitly enabled by default, but configuring the project to run with tests requires QEMU. As testing with QEMU is considered optional, it should be possible to disable tests when QEMU is not available or testing is not needed.
Since there is already an option for controlling FVP testing, this patch adds a similar option for QEMU, ENABLE_QEMU_TESTING, which instead defaults to ON. This can then be turned off when QEMU is not installed, so that configurations where QEMU is expected can suitably detect and show an error when it is missing.